Skip to content

fix: missing support for update_cond='never' condition in fsspec.generic.rsync #1852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: missing support for update_cond='never' condition in fsspec.generic.rsync #1852

wants to merge 1 commit into from

Conversation

obendidi
Copy link

@obendidi obendidi commented Jun 1, 2025 •
edited
Loading

The update_cond='never' was missing in the if-else block, this PR add support of that

@martindurant
Copy link
Member

Thank you - this looks like a well fixed oversight. We ought to have a test for it, if you might provide one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@obendidi @martindurant